Skip to content

feat: allow Fn::ImportValue for alarm topics #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2020
Merged

feat: allow Fn::ImportValue for alarm topics #384

merged 1 commit into from
Oct 31, 2020

Conversation

Luke-Davies
Copy link
Contributor

The same as #263 but for alarm topics.

      alarms:
        topics:
          ok:
            Fn::ImportValue: my-alarm-topic
          alarm:
            Fn::ImportValue: my-alarm-topic
        metrics:
          - executionsTimedOut
          - executionsFailed
          - executionsAborted

@theburningmonk theburningmonk merged commit db77965 into serverless-operations:master Oct 31, 2020
@Luke-Davies
Copy link
Contributor Author

Thanks for the review @theburningmonk.
Any chance of a patch release for this?

@ThrowingSpoon
Copy link

@theburningmonk Bumping as I could really use this in a release please.

@theburningmonk
Copy link
Collaborator

🎉 This PR is included in version 2.28.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@theburningmonk
Copy link
Collaborator

@ThrowingSpoon this has been released now but I haven't had a chance to test it out myself, so please let me know if there's any issues when you try it out.

ss-betseqnzr pushed a commit to BetSEQNZR/serverless-step-functions that referenced this pull request Sep 8, 2023
@theburningmonk
Merge pull request serverless-operations#384 from Luke-Davies/master
d322135 
feat: allow Fn::ImportValue for alarm topics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Luke-Davies @ThrowingSpoon @theburningmonk